New Upload & Edit Facility

Broken link? Feature request? Anything related to the Spectrum Computing website here.
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

Excellent! Thanks for the hard work, this database is getting better and better!
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

Ok, first question. If I want to remove a game from a group, for example, I want to remove https://spectrumcomputing.co.uk/index.p ... 96&id=2778 from "vector graphics" group, how I must proceed? Seems to me that a "no group" option should be present at the top? Or a checkbox?
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

Another thing. Seems that it is required to upload a file, even when you're only editing an entry.
User avatar
pavero
Dynamite Dan
Posts: 1569
Joined: Sat Dec 09, 2017 11:49 pm
Location: The Czech Republic
Contact:

Re: New Upload & Edit Facility

Post by pavero »

druellan wrote: Sun Nov 11, 2018 1:26 pm Ok, first question. If I want to remove a game from a group, for example, I want to remove https://spectrumcomputing.co.uk/index.p ... 96&id=2778 from "vector graphics" group, how I must proceed? Seems to me that a "no group" option should be present at the top? Or a checkbox?
Now you can only add or edit, not remove anything. :)
User avatar
Mike Davies
Microbot
Posts: 137
Joined: Mon Nov 13, 2017 10:11 am

Re: New Upload & Edit Facility

Post by Mike Davies »

Hi Rorthron, thanks for the feedback.
Rorthron wrote: Fri Nov 09, 2018 9:56 pm 1. I can't upload amendments to existing entries without attaching a file. The following error messages appear at the bottom of the form:

Notice: Undefined index: fileExt in /var/www/zxdb-edit/src/ZxdbEdit/EntryForm.php on line 301

Notice: Undefined index: fileExt in /var/www/zxdb-edit/src/ZxdbEdit/EntryForm.php on line 431
Ah, amendments to an existing entry files, that's something I didn't anticipate. I've added a fix that allows that now, so it should work now.
Rorthron wrote: Fri Nov 09, 2018 9:56 pm 2. The menu button in the top right appears as just a grey rectangle.
To help me replicate, can you post a screenshot along with the browser/OS you are using? Probably something CSS related.
User avatar
Mike Davies
Microbot
Posts: 137
Joined: Mon Nov 13, 2017 10:11 am

Re: New Upload & Edit Facility

Post by Mike Davies »

druellan wrote: Sun Nov 11, 2018 2:01 pm Another thing. Seems that it is required to upload a file, even when you're only editing an entry.
That's what Rorthron reported earlier too, and should now be fixed.
User avatar
Mike Davies
Microbot
Posts: 137
Joined: Mon Nov 13, 2017 10:11 am

Re: New Upload & Edit Facility

Post by Mike Davies »

pavero wrote: Sat Nov 10, 2018 7:22 pm I have tried to upload one missing Czech game - Transfer.
https://spectrumcomputing.co.uk/edit/en ... 72a3dde50d

I added four files - TAP+TZX+2xSCR, but only the last one was uploaded I guess. ;)
Thanks for the bug report. I'll look into it. Not sure what's causing that yet.
User avatar
Mike Davies
Microbot
Posts: 137
Joined: Mon Nov 13, 2017 10:11 am

Re: New Upload & Edit Facility

Post by Mike Davies »

pavero wrote: Sun Nov 11, 2018 4:48 pm
druellan wrote: Sun Nov 11, 2018 1:26 pm Ok, first question. If I want to remove a game from a group, for example, I want to remove https://spectrumcomputing.co.uk/index.p ... 96&id=2778 from "vector graphics" group, how I must proceed? Seems to me that a "no group" option should be present at the top? Or a checkbox?
Now you can only add or edit, not remove anything. :)
I'd suggest making a note of such corrections using the Comments box in the "General" section for now for anything that can't be handled by the current editing form.
User avatar
Rorthron
Dynamite Dan
Posts: 1644
Joined: Sun Nov 12, 2017 10:35 pm

Re: New Upload & Edit Facility

Post by Rorthron »

Mike Davies wrote: Sun Nov 11, 2018 6:26 pm
Rorthron wrote: Fri Nov 09, 2018 9:56 pm 2. The menu button in the top right appears as just a grey rectangle.
To help me replicate, can you post a screenshot along with the browser/OS you are using? Probably something CSS related.
It's Chrome 70.0.3538.80 for Android 8.0.0. I'll try to post an image. I'll also try testing it on a PC.
User avatar
Rorthron
Dynamite Dan
Posts: 1644
Joined: Sun Nov 12, 2017 10:35 pm

Re: New Upload & Edit Facility

Post by Rorthron »

It's the same on Firefox 63.0 2 and Edge 42.0.0.2741 for Android 8.0.0
User avatar
pavero
Dynamite Dan
Posts: 1569
Joined: Sat Dec 09, 2017 11:49 pm
Location: The Czech Republic
Contact:

Re: New Upload & Edit Facility

Post by pavero »

Mike Davies wrote: Sun Nov 11, 2018 6:32 pm
pavero wrote: Sat Nov 10, 2018 7:22 pm I have tried to upload one missing Czech game - Transfer.
https://spectrumcomputing.co.uk/edit/en ... 72a3dde50d

I added four files - TAP+TZX+2xSCR, but only the last one was uploaded I guess. ;)
Thanks for the bug report. I'll look into it. Not sure what's causing that yet.
At first I selected all four files one by one. And after then I pressed Save button.

If I press Save button after every file separatelly all works fine.
User avatar
Rorthron
Dynamite Dan
Posts: 1644
Joined: Sun Nov 12, 2017 10:35 pm

Re: New Upload & Edit Facility

Post by Rorthron »

Mike Davies wrote: Sun Nov 11, 2018 6:26 pm
Rorthron wrote: Fri Nov 09, 2018 9:56 pm 2. The menu button in the top right appears as just a grey rectangle.
To help me replicate, can you post a screenshot along with the browser/OS you are using? Probably something CSS related.
I can't take a screen shot, but it's as I described: the usual menu button, minus the three horizontal white lines.
User avatar
PeterJ
Site Admin
Posts: 6854
Joined: Thu Nov 09, 2017 7:19 pm
Location: Surrey, UK

Re: New Upload & Edit Facility

Post by PeterJ »

Evening [mention]Mike Davies[/mention]

I think [mention]Rorthron[/mention] is referring to this on the edit page:

Image

Compared to this on the website home page:

Image

It only happens on mobile view. Even though it is missing the horizontal lines I still find it functions fine and brings up the menu items when you click on it. At least in Google Chrome mobile.
User avatar
Rorthron
Dynamite Dan
Posts: 1644
Joined: Sun Nov 12, 2017 10:35 pm

Re: New Upload & Edit Facility

Post by Rorthron »

PeterJ wrote: Sun Nov 11, 2018 9:51 pm Evening @Mike Davies

I think @Rorthron is referring to this on the edit page:

Image

Compared to this on the website home page:

Image

It only happens on mobile view. Even though it is missing the horizontal lines I still find it functions fine and brings up the menu items when you click on it. At least in Google Chrome mobile.
Yes, that's it. It's pretty minor.
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

Hi! I'm going to try and start adding the Vector Graphics games changes (viewtopic.php?p=13332#p13332). There are a lot of games that are miscategorized as vector, so, in that case, since I can't remove title from a group, I'm going to leave a comment.
Ralf
Rick Dangerous
Posts: 2279
Joined: Mon Nov 13, 2017 11:59 am
Location: Poland

Re: New Upload & Edit Facility

Post by Ralf »

And I'll try to do some upload testing in the coming week. Couldn't devote much time to it recently but now it looks like I'll be having some more spare time.
User avatar
PeterJ
Site Admin
Posts: 6854
Joined: Thu Nov 09, 2017 7:19 pm
Location: Surrey, UK

Re: New Upload & Edit Facility

Post by PeterJ »

Thanks [mention]Ralf[/mention]

As much testing as possible would be much appreciated. Let's iron out any bugs before we go live.

Just a reminder that changes requested during the testing phase won't be actioned. Please use email or the forum for now.
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

Oh, Ok. Good to know then.
User avatar
R-Tape
Site Admin
Posts: 6353
Joined: Thu Nov 09, 2017 11:46 am

Re: New Upload & Edit Facility

Post by R-Tape »

druellan wrote: Sun Nov 18, 2018 11:30 pm Oh, Ok. Good to know then.
Don't worry though, nothing will be missed either way. I've been getting Pav's .txt files from it, and there's other stuff already there not announced on the forum that I'll follow up.

After we're done testing, I still think the juicier MIA stuff should be posted publicly so it can be enjoyed and discussed between updates.
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

R-Tape wrote: Mon Nov 19, 2018 9:35 am
druellan wrote: Sun Nov 18, 2018 11:30 pm Oh, Ok. Good to know then.
Don't worry though, nothing will be missed either way. I've been getting Pav's .txt files from it, and there's other stuff already there not announced on the forum that I'll follow up.

After we're done testing, I still think the juicier MIA stuff should be posted publicly so it can be enjoyed and discussed between updates.
Thanks! I was going to do it anyway, since it is a good "real life" tests for the platform.
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

Interesting, seems that the URL needs the extra slash at the end (https://spectrumcomputing.co.uk/edit/) otherwise it is invalid.
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

Also, I'm trying to upload a not-so-big file (7mb), and the upload fails with this error:

Image

Seems that the editor resets, losing all editions.
User avatar
R-Tape
Site Admin
Posts: 6353
Joined: Thu Nov 09, 2017 11:46 am

Re: New Upload & Edit Facility

Post by R-Tape »

druellan wrote: Mon Nov 19, 2018 11:15 am Also, I'm trying to upload a not-so-big file (7mb), and the upload fails with this error:

Image

Seems that the editor resets, losing all editions.
Ah, sorry, that's probably over the upload filesize limit. [mention]PeterJ[/mention] what's it set to?

For the moment could we say don't upload Hi-Res inlays to via this form. They are handled differently (I don't fully understand it). For now could you make available elsewhere online and they'll be dealt with. Apologies for the vagueness; we need to get this side of things sorted.
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

Sorry, another suggestion. When you finish an edit, and you get this message:
Image

A "New Edit" button there could be handy.
User avatar
druellan
Dynamite Dan
Posts: 1466
Joined: Tue Apr 03, 2018 7:19 pm

Re: New Upload & Edit Facility

Post by druellan »

R-Tape wrote: Mon Nov 19, 2018 11:21 am For the moment could we say don't upload Hi-Res inlays to via this form. They are handled differently (I don't fully understand it). For now could you make available elsewhere online and they'll be dealt with. Apologies for the vagueness; we need to get this side of things sorted.
Thanks! Yeah, I understand the idea is to have all that on Archive.org, but I think can be a good point to add an extra warning or just to display the max file size. This are PDFs, BTW, on a ZIP file, so, also in the future can be handy to have guidelines since the material can be very diverse.
Post Reply