Page 1 of 1

Comma search problem

Posted: Mon Apr 16, 2018 10:23 am
by PeteProdge
I, Of The Mask brings up no results.

I Of The Mask does bring up the game - I, of the Mask.

Re: Comma search problem

Posted: Mon Apr 16, 2018 10:28 am
by Ast A. Moore
Confirmed.

Re: Comma search problem

Posted: Mon Apr 16, 2018 3:03 pm
by Kweepa
The forum search is also crap :)
"I of the Mask" returns 0 results.
"I, of the Mask" also returns 0 results.

Re: Comma search problem

Posted: Mon Apr 16, 2018 5:29 pm
by Einar Saukas
PeteProdge wrote: Mon Apr 16, 2018 10:23 am I, Of The Mask brings up no results.

I Of The Mask does bring up the game - I, of the Mask.
The SC website needs to remove commas from title, author and publisher fields in advanced search, before searching them on ZXDB. The same applies to the text field in basic search.

[mention]PeterJ[/mention] can you please take a look at this?

Re: Comma search problem

Posted: Mon Apr 16, 2018 5:55 pm
by Einar Saukas
Kweepa wrote: Mon Apr 16, 2018 3:03 pm The forum search is also crap :)
"I of the Mask" returns 0 results.
"I, of the Mask" also returns 0 results.
There's definitely something wrong there.

Apparently when you search for "I of the Mask", the forum considers that "I" and "the" are common words that must be excluded from search. So it tries to find an exact match for the remaining words "of Mask". Evidently it won't find anything this way.

If you select "search for any items" instead of "all items", then it works as expected.

Re: Comma search problem

Posted: Mon Apr 16, 2018 6:02 pm
by Kweepa
Yeah, if it's going to do an exact match, it shouldn't exclude common words!

Re: Comma search problem

Posted: Mon Apr 16, 2018 8:32 pm
by PeterJ
Kweepa wrote: Mon Apr 16, 2018 3:03 pm The forum search is also crap :)
"I of the Mask" returns 0 results.
"I, of the Mask" also returns 0 results.
I'm not sure I would says it's crap [mention]Kweepa[/mention] :-) I have looked at the admin side of phpBB and it looks like you can't change the search behaviour of the forum search. If any other phpBB user knows different please let me know.

Thanks as always for bringing these things to our attention.

Re: Comma search problem

Posted: Mon Apr 16, 2018 8:40 pm
by PeterJ
Hi [mention]PeteProdge[/mention]

I, Of The Mask should now bring up results.

Thanks for letting us know.

Re: Comma search problem

Posted: Mon Apr 16, 2018 10:44 pm
by Einar Saukas
PeterJ wrote: Mon Apr 16, 2018 8:32 pm
Kweepa wrote: Mon Apr 16, 2018 3:03 pm The forum search is also crap :)
"I of the Mask" returns 0 results.
"I, of the Mask" also returns 0 results.
I'm not sure I would says it's crap @Kweepa :-) I have looked at the admin side of phpBB and it looks like you can't change the search behaviour of the forum search. If any other phpBB user knows different please let me know.
If this is a forum software bug and there's no available fix yet, perhaps you can simply change it to choose "search for any items" as default?

Re: Comma search problem

Posted: Tue Apr 17, 2018 6:11 am
by PeterJ
Hi [mention]Einar Saukas[/mention]

Having taken a look and checked on Google there seems to be no configuration options for search in the backend.

People will just need to change the search option if they don't first get results. I think the ignoring of common words is frequently done on search tools. The phpBB engine builds an index and looks for common words. I can rebuild the index but I don't think that would change anything.

Re: Comma search problem

Posted: Tue Apr 17, 2018 8:53 am
by hikoki
Hi Peter. There seems to be a solution here : http://www.runeaudio.com/forum/forum-se ... t1077.html

Re: Comma search problem

Posted: Tue Apr 17, 2018 11:53 am
by PeterJ
Thanks [mention]hikoki[/mention] I will give that a go.

I will post here when I have made the change, and if I can have some volunteers to review the impact on the quality of searches that would be appreciated.

PS. You win the Google searcher of the day award!

Re: Comma search problem

Posted: Tue Apr 17, 2018 12:10 pm
by hikoki
PeterJ wrote: Tue Apr 17, 2018 11:53 am PS. You win the Google searcher of the day award!
Ha! Googleosis tricks. I enclosed, with quotes, some of the words that the phpbb system complains of