Suggestions on formatting of code

[Einar Saukas]

Good point. I might add RR8 and RR9 to my macros file to remember how many bits are used, as I think RR and RRC are defined the wrong way round.

RRC means "Rotate Right Circular".

A bad name choice indeed.

[andydansby]

Nice to see everyone's approach.

I'm putting labels on a separate line to be more flexible with using descriptive names.

Code: Select all

	call clearPlayArea

announceLvl2:
	xor a
	ld (flagSkipSegment),a

My preference has been for camelCase, just easier on my eyes.

...So just out of interest (for someone who doesn't do a lot of 'modern' development), what is it about camel case that you like/prefer?

Or is it a habit thing that's been learned (e.g. Javascript)?

For me it comes to when I write multi-word long variable names. If you had a choice between myvariablename or my_variable_name vs myVariableName, I can read the camel case much easier. It became more of a habit after studying other people’s C code and influenced me.

[XoRRoX]

...So just out of interest (for someone who doesn't do a lot of 'modern' development), what is it about camel case that you like/prefer?

Or is it a habit thing that's been learned (e.g. Javascript)?

Same reason as Andy wrote. It visually breaks up multi-word expressions where one cannot use spaces without having to type underscores, which also makes them longer; waitForAnyKey, showBossDefeated.

I started doing that from the very beginning in my coding adventures way back in Turbo Pascal.

To let them start with a lowercase character is just something I saw recently in someone else's code and for some reason thought looked cool

[Bedazzle]

I know it doesn't make a jot of difference to the assembler, but it's interesting how some of you are using uppercase, and others lowercase.... Just be consistent I suppose is the answer.

CONSTANTS
IFDEF
MACRO
labels
code

[Bedazzle]

So no-one indenting for loops, conditional code etc ???

I do empty line after djnz, jr or jp

One call (or even several call's) is surrounded by empty line before and after.

[Bedazzle]

I use a copy an offline copy of this. I made a few corrections to it.

What kind of corrections?

[Ast A. Moore]

I use a copy an offline copy of this. I made a few corrections to it.

What kind of corrections?

It’s been a while; I don’t remember the details exactly, but some instruction descriptions were incorrect (or maybe it was the case of incorrectly indicated states of the flags). No showstoppers, though.