ZXSR bugs

This is the place to request ZXDB corrections (add missing data or fix incorrect information)

Moderators: druellan, pavero

sho
Dizzy
Posts: 67
Joined: Sun May 03, 2020 10:02 pm

Re: ZXSR bugs

Post by sho »

Vampyre wrote: Tue Jun 07, 2022 10:02 am Thanks guys.

I've gone through this thread, from first post to last, and corrected everything in ZXSR. There were some older ones which I was sure I had done which... well, I hadn't
I am not sure if I am missing something, like site updates lagging behind backend updates, but as far as I can see these have not been fixed:

viewtopic.php?p=73156#p73156

viewtopic.php?p=73525#p73525
User avatar
PeterJ
Site Admin
Posts: 6879
Joined: Thu Nov 09, 2017 7:19 pm
Location: Surrey, UK

Re: ZXSR bugs

Post by PeterJ »

@Sho,

@Vampyre is responsible for ZXSR. When he is ready, he provides an updated version to @Einar Saukas who incorporates it into ZXDB.

@Vampyre will post when the next update of ZXSR is complete.

Please see here:

viewtopic.php?p=100738#p100738
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

sho wrote: Tue Sep 20, 2022 3:10 pm I am not sure if I am missing something, like site updates lagging behind backend updates, but as far as I can see these have not been fixed:

viewtopic.php?p=73156#p73156

viewtopic.php?p=73525#p73525
@Vampyre fixed these bugs in ZXSR, but he did not release a new ZXSR yet. He wants to finish revising all Crash reviews first. Therefore neither ZXDB or SC have these fixes right now.

As soon as a new ZXSR is released, we will incorporate these fixes.
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

ZXSR contains 3 hardware reviews from SU #20 page 34 but they were incorrectly stored as page 35.
User avatar
Vampyre
Manic Miner
Posts: 839
Joined: Wed Nov 15, 2017 2:51 pm
Contact:

Re: ZXSR bugs

Post by Vampyre »

Einar Saukas wrote: Tue Sep 20, 2022 7:03 pm ZXSR contains 3 hardware reviews from SU #20 page 34 but they were incorrectly stored as page 35.
Thanks Einar. Looks like I've picked these up in the overhaul. But always good to highlight them just in case.
ZX Spectrum Reviews REST API: http://zxspectrumreviews.co.uk/
User avatar
StooB
Dynamite Dan
Posts: 1076
Joined: Mon Oct 22, 2018 11:03 am
Contact:

Re: ZXSR bugs

Post by StooB »

The reviews for The Living Daylights include a review of Viz from 1991:

https://spectrumcomputing.co.uk/zxsr.php?id=6
User avatar
Vampyre
Manic Miner
Posts: 839
Joined: Wed Nov 15, 2017 2:51 pm
Contact:

Re: ZXSR bugs

Post by Vampyre »

Thank you. Update will present in next release.
ZX Spectrum Reviews REST API: http://zxspectrumreviews.co.uk/
Hood
Drutt
Posts: 42
Joined: Thu Nov 11, 2021 7:09 am
Location: Czech Republic
Contact:

Re: ZXSR bugs

Post by Hood »

Dears, is it possible to use ZXDB as standart FTP server, to dowload ZX stuff from there?

I am writing FTP client on ZX, so such an FTP source for ZX soft would be great. Thanks.



Hood
User avatar
Vampyre
Manic Miner
Posts: 839
Joined: Wed Nov 15, 2017 2:51 pm
Contact:

Re: ZXSR bugs

Post by Vampyre »

Hood wrote: Tue Nov 15, 2022 1:50 pm Dears, is it possible to use ZXDB as standart FTP server, to dowload ZX stuff from there?

I am writing FTP client on ZX, so such an FTP source for ZX soft would be great. Thanks.



Hood
You're asking this in the wrong thread. This is for ZXSR, not ZXDB.
ZX Spectrum Reviews REST API: http://zxspectrumreviews.co.uk/
Hood
Drutt
Posts: 42
Joined: Thu Nov 11, 2021 7:09 am
Location: Czech Republic
Contact:

Re: ZXSR bugs

Post by Hood »

Sorry,and thanks for your reminder. Hood.
User avatar
Pobulous
Dynamite Dan
Posts: 1366
Joined: Wed Nov 15, 2017 12:51 pm

Re: ZXSR bugs

Post by Pobulous »

User avatar
Vampyre
Manic Miner
Posts: 839
Joined: Wed Nov 15, 2017 2:51 pm
Contact:

Re: ZXSR bugs

Post by Vampyre »

Cheers! Bit of a strange one but I think it's down to ZXSR review IDs referencing an incorrect ZXDBID.

It should have already been picked up in the post-Covid clean-sweep I've been doing for the last 2/3 of years (crikey - has it been that long...?). The good news is that I'll be releasing a new version within the next few weeks (but don't hold your breath) which will have tidied a load of anomalies like this up. I keep spotting things which leads onto other things.
ZX Spectrum Reviews REST API: http://zxspectrumreviews.co.uk/
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

Vampyre wrote: Wed Feb 22, 2023 10:57 am The good news is that I'll be releasing a new version within the next few weeks (but don't hold your breath)
Your warning came too late, I'm holding my breath already!!!
User avatar
Vampyre
Manic Miner
Posts: 839
Joined: Wed Nov 15, 2017 2:51 pm
Contact:

Re: ZXSR bugs

Post by Vampyre »

Aaaaaand I'm pleased to announce that the latest version of ZXSR has been released. Einar has been sent a copy which he will import into ZXDB. The API, after a few nightmare hours, is up and running with all the latest amendments. So the reviews on ZXSC will show the latest versions where they have been previously linked. To summarise:

- A CSV that Einar provided (during lockdown IIRC, so that's some indicator how long this has taken) where there are discrepancies between the reviews flagged in ZXDB (from SPOT and other sources) and those in ZXSR. I took this opportunity to go through all of the reviews in all of the magazines again and try to confirm things once and for all. It highlighted that there are plenty of discrepancies and errors in both databases.

- SAM reviews have been added. Why I was being so pedantic about it ONLY being Speccy reviews is a mystery. I blame the wife.

- Several non-Speccy book reviews added. ZX-81 for example.

- It fixed the long-standing Scooby Doo error. It's now correctly showing the reviews: https://spectrumcomputing.co.uk/zxsr.php?id=4365

- An overhaul of the 2,500 Crash reviews. Interestingly they weren't formatted as badly nor ridden with spelling errors as I'd feared. But the fact that the top of the reviews (which is practically all Crash reviews) were missing the "Producer", "Price", "Authors" panel has bugged me for years. Round about Issue 50 Crash decided to replace "Price" with a "humorous" label relevant to the title. Rex, for example, is now "Greenpeace Card" or the more common "Out Of Pocket". Hilarious isn't it? And they changed this so many times over the later years.

Thanks to everyone for their patience. I will not be leaving it so long between updates again.
ZX Spectrum Reviews REST API: http://zxspectrumreviews.co.uk/
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

Aaaaaand I'm pleased to announce I have been working hard to import all these changes into ZXDB. :)

My goal is to incorporate everything in the next ZXDB update, except for discrepancies that will take longer to sort out.
User avatar
Vampyre
Manic Miner
Posts: 839
Joined: Wed Nov 15, 2017 2:51 pm
Contact:

Re: ZXSR bugs

Post by Vampyre »

Drat!! Looks like I've made some proper cock-ups here and there was me thinking I'd been so careful.

Thanks for highlighting them Einar, I'll fix them for the next update and see if I can spot any others along the way. Apologies for this.
ZX Spectrum Reviews REST API: http://zxspectrumreviews.co.uk/
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

No problem! You have done an amazing job, there's nothing to apologize.

I will post here anything else I can find.
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

The Triad review from Crash #3 says both "Not Rated" and "Overall 55%":

https://spectrumcomputing.co.uk/zxsr.php?id=12195

The latter is correct.
User avatar
Vampyre
Manic Miner
Posts: 839
Joined: Wed Nov 15, 2017 2:51 pm
Contact:

Re: ZXSR bugs

Post by Vampyre »

All of those highlighted by Einar have been corrected and will be available in the next update.

Quite how I've added the reviews again without finding the originals... well, I just don't know how I've done it!
ZX Spectrum Reviews REST API: http://zxspectrumreviews.co.uk/
User avatar
Vampyre
Manic Miner
Posts: 839
Joined: Wed Nov 15, 2017 2:51 pm
Contact:

Re: ZXSR bugs

Post by Vampyre »

There were a few more duplicates, only a handful so it wasn't the mess I originally thought. They've all been corrected and will be present in the next update.
ZX Spectrum Reviews REST API: http://zxspectrumreviews.co.uk/
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

Vampyre wrote: Thu Mar 02, 2023 3:59 pm There were a few more duplicates
Please check your email.

Vampyre wrote: Thu Mar 02, 2023 3:59 pm only a handful so it wasn't the mess I originally thought.
Certainly not!!!
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

Crash review of Fantastic American Football starts on page 46, although the text only appears in page 47.

Crash review of Klax starts on page 42, although the text only appears in page 43.

PCG review of Deathchase starts on page 82, although the text only appears in page 83.
User avatar
Einar Saukas
Bugaboo
Posts: 3145
Joined: Wed Nov 15, 2017 2:48 pm

Re: ZXSR bugs

Post by Einar Saukas »

This YS #16 review starts at page 51:

https://spectrumcomputing.co.uk/zxsr.php?id=696
Post Reply